Hi Joel, > > > @@ -15,7 +16,7 @@ > > > > > > #include "clk-aspeed.h" > > > > > > -#define ASPEED_G6_NUM_CLKS 71 > > > +#define ASPEED_G6_NUM_CLKS 72 > > > > NUM_CLKS seems dangerous. Should we instead use > > ARRAY_SIZE(aspeed_g6_gates)? > > Yep, that would have saved me some time debugging. That would suit as > a separate change though, would you like it in the same series? No wait, it's not just ARRAY_SIZE(aspeed_g6_gates), there's a bunch of manually-configured clocks in the aspeed_g6_clk_data->hws[] array too. This might require a bit more of a restructure if we want to get rid of the NUM_CLKS definitions... Cheers, Jeremy
