On Mon, 27 Feb 2023 20:00:33 +0000, Conor Dooley wrote: > On Mon, Feb 27, 2023 at 06:12:40PM +0000, Conor Dooley wrote: >> On Thu, Feb 23, 2023 at 04:50:20PM +0800, Hal Feng wrote: >> > On Tue, 21 Feb 2023 16:03:08 +0100, Emil Renner Berthing wrote: >> > > On Tue, 21 Feb 2023 at 03:47, Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> wrote: >> > >> From: Emil Renner Berthing <kernel@xxxxxxxx> >> > >> >> > >> Add a minimal device tree for StarFive JH7110 VisionFive 2 board >> > >> which has version A and version B. Support booting and basic >> > >> clock/reset/pinctrl/uart drivers. >> > >> >> > >> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> >> > >> Signed-off-by: Emil Renner Berthing <kernel@xxxxxxxx> >> > >> Co-developed-by: Jianlong Huang <jianlong.huang@xxxxxxxxxxxxxxxx> >> > >> Signed-off-by: Jianlong Huang <jianlong.huang@xxxxxxxxxxxxxxxx> >> > >> Co-developed-by: Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> >> > >> Signed-off-by: Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> >> > >> --- >> > >> arch/riscv/boot/dts/starfive/Makefile | 6 +- >> > >> .../jh7110-starfive-visionfive-2-v1.2a.dts | 13 ++ >> > >> .../jh7110-starfive-visionfive-2-v1.3b.dts | 13 ++ >> > >> .../jh7110-starfive-visionfive-2.dtsi | 215 ++++++++++++++++++ >> > >> 4 files changed, 246 insertions(+), 1 deletion(-) >> > >> create mode 100644 arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dts >> > >> create mode 100644 arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dts >> > >> create mode 100644 arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> > >> >> > >> diff --git a/arch/riscv/boot/dts/starfive/Makefile b/arch/riscv/boot/dts/starfive/Makefile >> > >> index 039c143cba33..cd73519b907b 100644 >> > >> --- a/arch/riscv/boot/dts/starfive/Makefile >> > >> +++ b/arch/riscv/boot/dts/starfive/Makefile >> > >> @@ -1,2 +1,6 @@ >> > >> # SPDX-License-Identifier: GPL-2.0 >> > >> -dtb-$(CONFIG_SOC_STARFIVE) += jh7100-beaglev-starlight.dtb jh7100-starfive-visionfive-v1.dtb >> > >> +dtb-$(CONFIG_SOC_STARFIVE) += jh7100-beaglev-starlight.dtb >> > >> +dtb-$(CONFIG_SOC_STARFIVE) += jh7100-starfive-visionfive-v1.dtb >> > >> + >> > >> +dtb-$(CONFIG_SOC_STARFIVE) += jh7110-starfive-visionfive-2-v1.2a.dtb >> > >> +dtb-$(CONFIG_SOC_STARFIVE) += jh7110-starfive-visionfive-2-v1.3b.dtb >> >> If you could rebase on top of v6.3-rc1 for the next version & use ARCH_ >> not SOC_ here that'd be great. I will use the ARCH_ symbol instead and tell the other people from StarFive to do so. >> >> > >> +/ { >> > >> + aliases { >> > >> + serial0 = &uart0; >> > >> + i2c0 = &i2c0; >> > >> + i2c2 = &i2c2; >> > >> + i2c5 = &i2c5; >> > >> + i2c6 = &i2c6; >> > > >> > > Let's keep these sorted alphabetically. >> > >> > OK, will fix it. >> > >> >> > > It would be great to have some sort of order to this file so it's >> > > obvious where to add new nodes. I suggest we do >> > > - root node >> > > - external clocks >> > > - other node references in alphabetical order >> > > >> > > You're almost there with this patch except the uart0 node is out of place. >> > >> > Will fix accordingly. Thanks for your suggestions. >> >> With Emil's suggestions implemented: >> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Actually, there's one thing that I don't think was (explicitly?) mentioned, > could you sort the external clocks alphanumerically too? OK. I will sort them in the next version. Thanks. Best regards, Hal