On 2023/2/21 21:37, Krzysztof Kozlowski wrote: > On 21/02/2023 14:01, Xingyu Wu wrote: >> On 2023/2/21 19:25, Krzysztof Kozlowski wrote: >>> On 21/02/2023 09:33, Xingyu Wu wrote: >>>> Add bindings for the System-Top-Group clock and reset generator (STGCRG) >>>> on the JH7110 RISC-V SoC by StarFive Ltd. >>>> >>>> Signed-off-by: Xingyu Wu <xingyu.wu@xxxxxxxxxxxxxxxx> >>> >>> >>>> + }; >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index 93eb504c3b21..2e70c9f21989 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -19914,6 +19914,7 @@ F: arch/riscv/boot/dts/starfive/ >>>> STARFIVE JH71X0 CLOCK DRIVERS >>>> M: Emil Renner Berthing <kernel@xxxxxxxx> >>>> M: Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> >>>> +M: Xingyu Wu <xingyu.wu@xxxxxxxxxxxxxxxx> >>> >>> No improvements here. You add here new bindings for one device and then >>> - without explanation - add yourself to all Starfive clock bindings. >>> Either explain it or drop it or move it to separate patch. >>> >>> You already got comment for this. >>> >> >> Sorry, I didn't understand what you meant before. Now my understanding is that, >> If I improvements JH71X0 driver no JH7110 driver, I could add this here. Right? >> >> Is it OK if I do it this way to move it to separate patch like this?: >> +STARFIVE JH7110 STG CLOCK DRIVERS >> +M: Xingyu Wu <xingyu.wu@xxxxxxxxxxxxxxxx> > > If you want to be the maintainer of all drivers, add separate commit for > this, so this is obvious. Or at least explain this change in commit msg. > OK, got it. Thanks. Best regard, Xingyu Wu
