Hi Joerg, On 2/3/23 04:21, Joerg Roedel wrote: > On Fri, Jan 20, 2023 at 04:11:30PM +0100, Joerg Roedel wrote: >> There is a conflict between these patches and changes in the IOMMU >> core branch. With those merged in there is a compile warning about >> sun50i_iommu_detach_domain() being unused. Fixing that requires >> removing of 3-4 functions, which I am not sure is the right >> solution. >> >> Once this is fixed I will include the arm/allwinner branch into my >> next branch again. > > Since there was no reply to this I nuked the patches from the IOMMU > tree. If this is still relevant please resubmit them after the next > merge window. I am not sure what the right solution is here either, and I have not had the chance to look at it again. With my limited understanding of how the default domain logic works, and the fact that the IOMMU driver only supports one domain, it seems the driver should keep that domain enabled permanently, regardless of which devices are attached. So my patch 2 would be wrong. I will investigate and send a v3 after the merge window. Regards, Samuel
