On 23/01/2023 18:41, Stefan Hansson wrote: >>> >>> 2. You base on other SoC but you do not include its compatibles. Why? Is >>> it intended? None of the properties applicable to other SoC will match >>> here, thus I actually wonder if you run dtbs_check... > > Sorry, I forgot about running dtbs_check. However, I'm not sure I > understand the question. What do you mean by that I don't include its > compatibles? I understood you include the msm8226.dtsi which is a different SoC. If you include it, you get all of its content. We do it only for compatible devices, but your device does not indicate compatibility with msm8226. > > I ran `$ make dtbs_check DT_SCHEMA_FILES=qcom.yaml` locally just now, > and it only gave me errors from the qcom-msm8974pro-oneplus-bacon dtb. > Maybe I'm running it wrong? No clue, I cannot test because your patches do not apply cleanly. Best regards, Krzysztof
