On 23/01/2023 18:10, Krzysztof Kozlowski wrote: > On 22/01/2023 15:47, Stefan Hansson wrote: >> MSM8926 (also known as Snapdragon 400) is very similar to MSM8226 and >> APQ8026 with the primary difference being that it features an LTE modem >> unlike the former two which feature a 3G modem and a GPS-only modem, >> respectively. >> >> This also documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) >> which is a tablet by Samsung based on the MSM8926 SoC. >> >> Signed-off-by: Stefan Hansson <newbyte@xxxxxxxxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml >> index 47913a8e3eea..7a0b2088ead9 100644 >> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >> @@ -35,6 +35,7 @@ description: | >> mdm9615 >> msm8226 >> msm8916 >> + msm8926 >> msm8953 >> msm8956 >> msm8974 >> @@ -219,6 +220,11 @@ properties: >> - const: qcom,msm8916-v1-qrd/9-v1 >> - const: qcom,msm8916 >> >> + - items: >> + - enum: >> + - samsung,matisselte > > 1. matisse is the code name, lte is version/suffix. I don't think they > should be together, because then it looks like "matisselte" is a name. > It actually sounds like one word. Update: there is already matisse-wifi, so please follow the same naming convention. Version suffix should be separated with hyphen. > > 2. You base on other SoC but you do not include its compatibles. Why? Is > it intended? None of the properties applicable to other SoC will match > here, thus I actually wonder if you run dtbs_check... Best regards, Krzysztof
