Re: [PATCH V6 0/3] Add S4 SoC PLL and Peripheral clock controller

Yu Tu <yu.tu@xxxxxxxxxxx> · Fri, 20 Jan 2023 10:31:33 +0800

Hi Jerome,

On 2023/1/19 19:18, Jerome Brunet wrote:
[ EXTERNAL EMAIL ]

On Mon 16 Jan 2023 at 15:42, Yu Tu <yu.tu@xxxxxxxxxxx> wrote:

1. Add S4 SoC PLL and Peripheral clock controller dt-bindings.
2. Add PLL and Peripheral clock controller driver for S4 SOC.

Yu Tu (3):
   dt-bindings: clock: document Amlogic S4 SoC PLL & peripheral clock
     controller
   clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver
   clk: meson: s4: add support for Amlogic S4 SoC peripheral clock
     controller

You are adding 2 controller driver with this series.
Making 2 driver patches on clk/ is good. Please do the same for the bindings

okay.I will change the next edition as you suggest.

Please check Krzysztof's opinion. Do you agree? Thank you!

V5 -> V6: Change send patch series, as well change format and clock flags.
V4 -> V5: change format and clock flags and adjust the patch series as suggested
by Jerome.
V3 -> V4: change format and clock flags.
V2 -> V3: Use two clock controller.
V1 -> V2: Change format as discussed in the email.

Link:https://lore.kernel.org/all/20221123021346.18136-1-yu.tu@xxxxxxxxxxx/

  .../clock/amlogic,s4-peripherals-clkc.yaml    |  104 +
  .../bindings/clock/amlogic,s4-pll-clkc.yaml   |   50 +
  MAINTAINERS                                   |    1 +
  drivers/clk/meson/Kconfig                     |   25 +
  drivers/clk/meson/Makefile                    |    2 +
  drivers/clk/meson/s4-peripherals.c            | 3874 +++++++++++++++++
  drivers/clk/meson/s4-peripherals.h            |  218 +
  drivers/clk/meson/s4-pll.c                    |  875 ++++
  drivers/clk/meson/s4-pll.h                    |   88 +
  .../clock/amlogic,s4-peripherals-clkc.h       |  131 +
  .../dt-bindings/clock/amlogic,s4-pll-clkc.h   |   30 +
  11 files changed, 5398 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/clock/amlogic,s4-peripherals-clkc.yaml
  create mode 100644 Documentation/devicetree/bindings/clock/amlogic,s4-pll-clkc.yaml
  create mode 100644 drivers/clk/meson/s4-peripherals.c
  create mode 100644 drivers/clk/meson/s4-peripherals.h
  create mode 100644 drivers/clk/meson/s4-pll.c
  create mode 100644 drivers/clk/meson/s4-pll.h
  create mode 100644 include/dt-bindings/clock/amlogic,s4-peripherals-clkc.h
  create mode 100644 include/dt-bindings/clock/amlogic,s4-pll-clkc.h

base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2