Re: [RFC] ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Nov 19, 2022 at 06:24:36PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@xxxxxxx>
> 
> The following build warning is seen when running:
> make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml
> 
> arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
> 	From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
> 
> The imx6qdl-gw560x board does not expose the UART RTS and CTS
> as native pins, so 'uart-has-rtscts' should not be used.
> 
> Fix the problem by removing the 'uart-has-rtscts' property.
> 
> Fixes: b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")
> Signed-off-by: Fabio Estevam <festevam@xxxxxxx>
> ---
> Hi,
> 
> My understanding is that uart-has-rtscts indicates that the UART RTS
> and CTS pins are used natively and we cannot use uart-has-rtscts with
> rts-gpios.
> 
> If this is correct, then I can also submit a patch fixing the arm64 Gateworks
> boards too.

Tim,

Any comments?

Shawn

> 
>  arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-gw560x.dtsi b/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
> index 4bc4371e6bae..4b81a975c979 100644
> --- a/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
> @@ -632,7 +632,6 @@ &ssi1 {
>  &uart1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_uart1>;
> -	uart-has-rtscts;
>  	rts-gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>;
>  	status = "okay";
>  };
> -- 
> 2.25.1
> 



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux