Re: [RFC] ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 30, 2022 at 11:04 PM Shawn Guo <shawnguo@xxxxxxxxxx> wrote:
>
> On Sat, Nov 19, 2022 at 06:24:36PM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <festevam@xxxxxxx>
> >
> > The following build warning is seen when running:
> > make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml
> >
> > arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
> >       From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
> >
> > The imx6qdl-gw560x board does not expose the UART RTS and CTS
> > as native pins, so 'uart-has-rtscts' should not be used.
> >
> > Fix the problem by removing the 'uart-has-rtscts' property.
> >
> > Fixes: b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")
> > Signed-off-by: Fabio Estevam <festevam@xxxxxxx>
> > ---
> > Hi,
> >
> > My understanding is that uart-has-rtscts indicates that the UART RTS
> > and CTS pins are used natively and we cannot use uart-has-rtscts with
> > rts-gpios.
> >
> > If this is correct, then I can also submit a patch fixing the arm64 Gateworks
> > boards too.
>
> Tim,
>
> Any comments?
>
> Shawn

Shawn and Fabio,

Yes Fabio's change makes sense. Sorry, I missed this as I wasn't on
the 'to' list.

Fabio has sent a patch so I'll ack it there.

Best Regards,

Tim



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux