Hi Prabhakar, On Wed, Dec 21, 2022 at 1:03 AM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Document RZ/G2UL (R9A07G043U) IRQC bindings. The IRQC block on RZ/G2UL SoC > is almost identical to one found on the RZ/G2L SoC the only difference > being it can support BUS_ERR_INT for which it has additional registers. > Hence new generic compatible string "renesas,rzg2ul-irqc" is added for > RZ/G2UL SoC. > > Now that we have additional interrupt for RZ/G2UL and RZ/Five SoC > interrupt-names property is added so that we can parse them based on > names. > > While at it updated the example node to four spaces and added > interrupt-names property. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > --- > v1- > v2 > * Dropped RB tags > * Added generic compatible string for rzg2ul > * Added interrupt-names > * Added checks for RZ/G2UL to make sure interrupts are 42 and interrupt-names > * Updated example node with interrupt-names > * Used 4 spaces for example node Thanks for the update! > --- a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml > @@ -19,16 +19,19 @@ description: | > - NMI edge select (NMI is not treated as NMI exception and supports fall edge and > stand-up edge detection interrupts) > > -allOf: > - - $ref: /schemas/interrupt-controller.yaml# > - > properties: > compatible: > - items: > - - enum: > - - renesas,r9a07g044-irqc # RZ/G2{L,LC} > - - renesas,r9a07g054-irqc # RZ/V2L > - - const: renesas,rzg2l-irqc > + oneOf: > + - items: > + - enum: > + - renesas,r9a07g044-irqc # RZ/G2{L,LC} > + - renesas,r9a07g054-irqc # RZ/V2L > + - const: renesas,rzg2l-irqc > + > + - items: > + - enum: > + - renesas,r9a07g043u-irqc # RZ/G2UL > + - const: renesas,rzg2ul-irqc I'm not sure it's worth splitting into RZ/G2L and RZ/G2UL alike variants, and adding the "renesas,rzg2ul-irqc" family-specific compatible value. You can easily handle the difference by the presence (or absence) of the "bus-err" interrupt source. I understand there "renesas,r9a07g043f-irqc" will be added later to support RZ/Five? > > '#interrupt-cells': > description: The first cell should contain external interrupt number (IRQ0-7) and the > @@ -44,7 +47,96 @@ properties: > maxItems: 1 > > interrupts: > - maxItems: 41 > + minItems: 41 > + items: > + - description: NMI interrupt > + - description: IRQ0 interrupt > + - description: IRQ1 interrupt > + - description: IRQ2 interrupt > + - description: IRQ3 interrupt > + - description: IRQ4 interrupt > + - description: IRQ5 interrupt > + - description: IRQ6 interrupt > + - description: IRQ7 interrupt > + - description: GPIO interrupt, TINT0 > + - description: GPIO interrupt, TINT1 > + - description: GPIO interrupt, TINT2 > + - description: GPIO interrupt, TINT3 > + - description: GPIO interrupt, TINT4 > + - description: GPIO interrupt, TINT5 > + - description: GPIO interrupt, TINT6 > + - description: GPIO interrupt, TINT7 > + - description: GPIO interrupt, TINT8 > + - description: GPIO interrupt, TINT9 > + - description: GPIO interrupt, TINT10 > + - description: GPIO interrupt, TINT11 > + - description: GPIO interrupt, TINT12 > + - description: GPIO interrupt, TINT13 > + - description: GPIO interrupt, TINT14 > + - description: GPIO interrupt, TINT15 > + - description: GPIO interrupt, TINT16 > + - description: GPIO interrupt, TINT17 > + - description: GPIO interrupt, TINT18 > + - description: GPIO interrupt, TINT19 > + - description: GPIO interrupt, TINT20 > + - description: GPIO interrupt, TINT21 > + - description: GPIO interrupt, TINT22 > + - description: GPIO interrupt, TINT23 > + - description: GPIO interrupt, TINT24 > + - description: GPIO interrupt, TINT25 > + - description: GPIO interrupt, TINT26 > + - description: GPIO interrupt, TINT27 > + - description: GPIO interrupt, TINT28 > + - description: GPIO interrupt, TINT29 > + - description: GPIO interrupt, TINT30 > + - description: GPIO interrupt, TINT31 > + - description: Bus error interrupt > + > + interrupt-names: > + minItems: 41 > + items: > + - const: nmi > + - const: irq0 > + - const: irq1 > + - const: irq2 > + - const: irq3 > + - const: irq4 > + - const: irq5 > + - const: irq6 > + - const: irq7 > + - const: tint0 > + - const: tint1 > + - const: tint2 > + - const: tint3 > + - const: tint4 > + - const: tint5 > + - const: tint6 > + - const: tint7 > + - const: tint8 > + - const: tint9 > + - const: tint10 > + - const: tint11 > + - const: tint12 > + - const: tint13 > + - const: tint14 > + - const: tint15 > + - const: tint16 > + - const: tint17 > + - const: tint18 > + - const: tint19 > + - const: tint20 > + - const: tint21 > + - const: tint22 > + - const: tint23 > + - const: tint24 > + - const: tint25 > + - const: tint26 > + - const: tint27 > + - const: tint28 > + - const: tint29 > + - const: tint30 > + - const: tint31 > + - const: bus-err Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds