On 2022/12/16 17:22, Ulf Hansson wrote: > On Fri, 16 Dec 2022 at 03:02, William Qiu <william.qiu@xxxxxxxxxxxxxxxx> wrote: >> >> >> >> On 2022/12/7 21:17, William Qiu wrote: >> > Hi, >> > >> > This patchset adds initial rudimentary support for the StarFive >> > designware mobile storage host controller driver. And this driver will >> > be used in StarFive's visionfive-v2 board. The main purpose of adding >> > this driver is to accommodate the ultra-high speed mode of eMMC. >> > >> > The patch series is based on v6.1-rc5. >> > >> > -- William >> > >> > William Qiu (3): >> > dt-bindings: mmc: Add bindings for StarFive >> > mmc: starfive: Add sdio/emmc driver support >> > riscv: dts: starfive: Add mmc node >> > >> > .../bindings/mmc/starfive,jh7110-sdio.yaml | 71 +++++++ >> > MAINTAINERS | 6 + >> > .../jh7110-starfive-visionfive-v2.dts | 25 +++ >> > arch/riscv/boot/dts/starfive/jh7110.dtsi | 38 ++++ >> > drivers/mmc/host/Kconfig | 10 + >> > drivers/mmc/host/Makefile | 1 + >> > drivers/mmc/host/dw_mmc-starfive.c | 197 ++++++++++++++++++ >> > 7 files changed, 348 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/mmc/starfive,jh7110-sdio.yaml >> > create mode 100644 drivers/mmc/host/dw_mmc-starfive.c >> > >> > -- >> > 2.34.1 >> > >> >> Hi Jaehoon/Ulf, >> >> Could you please help to review and provide comments on this patch series? >> Thank you in advance. > > Hi William, > > Looks like you have received plenty of good comments already and there > are a lot of things for you to update. That said, I think it makes > better sense for me to look at the next version instead. > Fine, I'll do that then. Thanks William Qiu >> >> Best regards, >> William Qiu > > Kind regards > Uffe