On 14/12/2022 14:41, Krzysztof Kozlowski wrote: > On 14/12/2022 14:24, Emekcan Aras wrote: >> From: Emekcan Aras <Emekcan.Aras@xxxxxxx> >> > > Use subject prefixes matching the subsystem (git log --oneline -- ...). > You already got such comment for v1... so do not ignore it but implement > instead. > >> Corstone500[0] is a platform from arm, which includes Cortex-A cores and >> ideal starting point for feature rich System on Chip (SoC) designs >> based on the Cortex-A5 core. >> >> These device trees contains the necessary bits to support the >> Corstone 500 FVP (Fixed Virtual Platform) and the >> FPGA MPS3 board. >> >> 0: https://developer.arm.com/documentation/102262/0000 >> >> Signed-off-by: Emekcan Aras <emekcan.aras@xxxxxxx> >> --- >> arch/arm/boot/dts/corstone500.dts | 181 ++++++++++++++++++++++++++++++ >> 1 file changed, 181 insertions(+) >> create mode 100644 arch/arm/boot/dts/corstone500.dts > > How do you test it? I do not see a way to compile it... > > You need to include it in maintainers entry and CC relevant maintainers. > >> >> diff --git a/arch/arm/boot/dts/corstone500.dts b/arch/arm/boot/dts/corstone500.dts >> new file mode 100644 >> index 000000000000..976aa333ffbc >> --- /dev/null >> +++ b/arch/arm/boot/dts/corstone500.dts >> @@ -0,0 +1,181 @@ >> +// SPDX-License-Identifier: GPL-2.0 or MIT >> +/* >> + * Copyright (c) 2022, Arm Limited. All rights reserved. >> + * >> + */ >> + >> + > > Just one blank line > >> +#include <dt-bindings/interrupt-controller/arm-gic.h> >> + >> +/ { >> + model = "ARM Corstone500"; >> + compatible = "arm,corstone500"; > > No DTSI? No board or platform compatible? How is it going to be used by > anyone else? I guess this is the same as concept as Corstone 1000. Best regards, Krzysztof
