On 2022/12/8 16:59, Krzysztof Kozlowski wrote: > On 08/12/2022 09:45, Walker Chen wrote: >> Add bindings for Power Management Unit (PMU) on the StarFive JH71XX SoC. >> >> Signed-off-by: Walker Chen <walker.chen@xxxxxxxxxxxxxxxx> >> --- >> .../bindings/power/starfive,jh71xx-pmu.yaml | 45 +++++++++++++++++++ >> .../dt-bindings/power/starfive,jh7110-pmu.h | 17 +++++++ >> 2 files changed, 62 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml > > Filename matching compatible, so: > starfive,jh7110-pmu.yaml OK, will be fixed. > > >> create mode 100644 include/dt-bindings/power/starfive,jh7110-pmu.h >> >> diff --git a/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml b/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml >> new file mode 100644 >> index 000000000000..f308ae136a57 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml >> @@ -0,0 +1,45 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/power/starfive,jh71xx-pmu.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive JH71xx Power Management Unit >> + >> +maintainers: >> + - Walker Chen <walker.chen@xxxxxxxxxxxxxxxx> >> + >> +description: | >> + StarFive JH71xx SoCs include support for multiple power domains which can be >> + powered on/off by software based on different application scenes to save power. >> + >> +properties: >> + compatible: >> + - enum: > > Wrong indentation. > > Does not look like you tested the bindings. Please run `make > dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). This is my mistake, I forgot to make dt_binding_check for .yaml file. > >> + - starfive,jh7110-pmu >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + "#power-domain-cells": >> + const: 1 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - "#power-domain-cells" >> + > > Best regards, > Krzysztof >
