Hi Marek, On Sun, 2022-12-11 at 03:57 +0100, Marek Vasut wrote: > The power-domains property is mandatory on i.MX8M Mini, Nano, Plus. > Document the property and mark it as required on the aforementioned > variants of the IP, present in those SoCs. > > Signed-off-by: Marek Vasut <marex@xxxxxxx> > --- > Cc: Fabio Estevam <festevam@xxxxxxxxx> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx> > Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > Cc: NXP Linux Team <linux-imx@xxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Shawn Guo <shawnguo@xxxxxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > To: devicetree@xxxxxxxxxxxxxxx > --- > .../devicetree/bindings/display/fsl,lcdif.yaml | 14 > ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > index 876015a44a1e6..31847efedd8f9 100644 > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -52,6 +52,9 @@ properties: > interrupts: > maxItems: 1 > > + power-domains: > + maxItems: 1 > + > port: > $ref: /schemas/graph.yaml#/properties/port > description: The LCDIF output port > @@ -87,6 +90,17 @@ allOf: > maxItems: 1 > clock-names: > maxItems: 1 > + - if: > + properties: > + compatible: > + contains: > + enum: There is a power-domains property in the lcdif node of imx6sl.dtsi, so care to add '- fsl,imx6sl-lcdif' here too? The patch subject and commit message need to be updated correspondingly then. Regards, Liu Ying > + - fsl,imx8mm-lcdif > + - fsl,imx8mn-lcdif > + - fsl,imx8mp-lcdif > + then: > + required: > + - power-domains > > examples: > - |