On 08/12/2022 09:45, Walker Chen wrote: > Add bindings for Power Management Unit (PMU) on the StarFive JH71XX SoC. > > Signed-off-by: Walker Chen <walker.chen@xxxxxxxxxxxxxxxx> > + }; > diff --git a/include/dt-bindings/power/starfive,jh7110-pmu.h b/include/dt-bindings/power/starfive,jh7110-pmu.h > new file mode 100644 > index 000000000000..73c6a79a2181 > --- /dev/null > +++ b/include/dt-bindings/power/starfive,jh7110-pmu.h > @@ -0,0 +1,17 @@ > +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */ Why different license than the bindings? MIT is pretty compatible, but if it does not matter for you, keep same licenses as bindings. > +/* > + * Copyright (C) 2022 StarFive Technology Co., Ltd. > + * Author: Walker Chen <walker.chen@xxxxxxxxxxxxxxxx> > + */ > +#ifndef __DT_BINDINGS_POWER_JH7110_POWER_H__ > +#define __DT_BINDINGS_POWER_JH7110_POWER_H__ > + > +#define JH7110_PD_SYSTOP 0 > +#define JH7110_PD_CPU 1 > +#define JH7110_PD_GPUA 2 > +#define JH7110_PD_VDEC 3 > +#define JH7110_PD_VOUT 4 > +#define JH7110_PD_ISP 5 > +#define JH7110_PD_VENC 6 > + > +#endif Best regards, Krzysztof
