On 02/12/2022 10:51, Dmitry Rokosov wrote: > On Thu, Dec 01, 2022 at 10:10:04PM -0600, Rob Herring wrote: >> >> On Fri, 02 Dec 2022 01:56:53 +0300, Dmitry Rokosov wrote: >>> From: Jian Hu <jian.hu@xxxxxxxxxxx> >>> >>> Add the documentation to support Amlogic A1 PLL clock driver, >>> and add A1 PLL clock controller bindings. >>> >>> Signed-off-by: Jian Hu <jian.hu@xxxxxxxxxxx> >>> Signed-off-by: Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxx> >>> --- >>> .../bindings/clock/amlogic,a1-pll-clkc.yaml | 52 +++++++++++++++++++ >>> include/dt-bindings/clock/a1-pll-clkc.h | 16 ++++++ >>> 2 files changed, 68 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml >>> create mode 100644 include/dt-bindings/clock/a1-pll-clkc.h >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> ./Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml:26:6: [warning] wrong indentation: expected 6 but found 5 (indentation) >> >> dtschema/dtc warnings/errors: >> ./Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml: $id: relative path/filename doesn't match actual path or filename >> expected: http://devicetree.org/schemas/clock/amlogic,a1-pll-clkc.yaml# >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.example.dtb: pll-clock-controller@7c80: reg: [[0, 31872], [0, 396]] is too long >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml >> >> doc reference errors (make refcheckdocs): >> >> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221201225703.6507-2-ddrokosov@xxxxxxxxxxxxxx >> >> The base for the series is generally the latest rc1. A different dependency >> should be noted in *this* patch. >> >> If you already ran 'make dt_binding_check' and didn't see the above >> error(s), then make sure 'yamllint' is installed and dt-schema is up to >> date: >> >> pip3 install dtschema --upgrade >> >> Please check and re-submit after running the above command yourself. Note >> that DT_SCHEMA_FILES can be set to your schema file to speed up checking >> your schema. However, it must be unset to test all examples with your schema. >> > > Please find all fixes of above warnings and errors in the my patch > located at the link: > > https://lore.kernel.org/linux-amlogic/20221201225703.6507-9-ddrokosov@xxxxxxxxxxxxxx/ Why? This patch here is broken and it should be fixed. Don't apply broken patches... Best regards, Krzysztof
