On 28.11.2022 18:37, Luca Weiss wrote: > Configure the node for the NQ310 chip found on this device, which is > compatible with generic nxp-nci-i2c driver. > > Signed-off-by: Luca Weiss <luca@xxxxxxxxx> > --- > RESEND to fix Cc > > arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts > index 2920504461d3..fde93cbcd180 100644 > --- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts > +++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts > @@ -63,6 +63,21 @@ touchscreen@48 { > }; > }; > > +&i2c_5 { > + status = "okay"; > + > + nfc@28 { > + compatible = "nxp,nq310", "nxp,nxp-nci-i2c"; Unless there was some binding change (that was not emailed to me with this email, I only got 2/2), only "nxp,nxp-nci-i2c" and "nxp,pn547", "nxp,nxp-nci-i2c" are allowed. The node looks good though. Konrad > + reg = <0x28>; > + > + interrupt-parent = <&tlmm>; > + interrupts = <17 IRQ_TYPE_LEVEL_HIGH>; > + > + enable-gpios = <&tlmm 16 GPIO_ACTIVE_HIGH>; > + firmware-gpios = <&tlmm 62 GPIO_ACTIVE_HIGH>; > + }; > +}; > + > &pm8953_resin { > status = "okay"; > linux,code = <KEY_VOLUMEDOWN>;