Re: [PATCH v2 1/2] ARM: dts: msm8974: castor: Define pm8841 regulators

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Montag, 21. November 2022 23:32:22 CET Konrad Dybcio wrote:
> On 21.11.2022 22:22, Luca Weiss wrote:
> > From: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > 
> > Define the pm8841 regulators under SMD/RPM, to allow the modem
> > remoteproc to set the voltage during boot of the remote processor.
> > 
> > Entries are just copied from the Honami dts.
> 
> I hope it was supposed to be "identical to" and not "copied and hoped it
> would be ok" :/

Blame Bjorn from many years ago :P

But I just double checked and in some Sony msm8974 kernel sources I have on my 
computer (https://github.com/rcstar6696/android_kernel_sony_msm8974 branch 
cm-14.1) all Sony devices have the same values these pm8841 regulators, none 
have it overriden from what I could find. So should be fine.

Regards
Luca

> 
> Maybe I'm a bit picky, but I suppose this is said in a misleading way..
> 
> Konrad
> 
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > Signed-off-by: Luca Weiss <luca@xxxxxxxxx>
> > ---
> > Changes in v2:
> > * new patch in this series
> > 
> >  ...-msm8974pro-sony-xperia-shinano-castor.dts | 24 +++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> > 
> > diff --git
> > a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> > b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts index
> > 3f45f5c5d37b..2c33f84a6e4e 100644
> > --- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> > +++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> > @@ -319,6 +319,30 @@ led@7 {
> > 
> >  };
> >  
> >  &rpm_requests {
> > 
> > +	pm8841-regulators {
> > +		compatible = "qcom,rpm-pm8841-regulators";
> > +
> > +		pm8841_s1: s1 {
> > +			regulator-min-microvolt = <675000>;
> > +			regulator-max-microvolt = <1050000>;
> > +		};
> > +
> > +		pm8841_s2: s2 {
> > +			regulator-min-microvolt = <500000>;
> > +			regulator-max-microvolt = <1050000>;
> > +		};
> > +
> > +		pm8841_s3: s3 {
> > +			regulator-min-microvolt = <500000>;
> > +			regulator-max-microvolt = <1050000>;
> > +		};
> > +
> > +		pm8841_s4: s4 {
> > +			regulator-min-microvolt = <500000>;
> > +			regulator-max-microvolt = <1050000>;
> > +		};
> > +	};
> > +
> > 
> >  	pm8941-regulators {
> >  	
> >  		compatible = "qcom,rpm-pm8941-regulators";







[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux