Re: [PATCH v1 2/2] leds: add aw20xx driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25.11.2022 11:19, Krzysztof Kozlowski wrote:
>> +    $ ls -l /sys/bus/i2c/devices/xxxx/pattern0/
>> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 clear_leds
>> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 fall_time
>> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 loop_begin
>> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 loop_end_on
>> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 max_breathing_level
>> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 min_breathing_level
>> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 mode
>> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 off_time
>> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 on_time
>> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 ramp
>> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 repeat
>> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 rise_time
>> +    -r--r--r--    1 root     root          4096 Jan  1 00:00 running
>> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 select_leds
>> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 start
>> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 toggle
> 
> sysfs documentation goes to Documentation/ABI/

Should I add it to Documentation/ABI/testing/sysfs-class-led-driver-aw200xx?
Is my understanding correct?
Is KernelVersion parameter required?


>> +	chip = devm_kzalloc(&client->dev,
>> +			    struct_size(chip, leds, count),
> 
> sizeof(*chip)

Unfortunately, it will not work. Because I want to calculate the whole
size of chip structure, it has flexible array member inside.

-- 
Best Regards,
Kurbanov Martin





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux