On Thu, Nov 24, 2022 at 02:42:20PM +0100, Heiko Stübner wrote: > Am Donnerstag, 24. November 2022, 14:04:41 CET schrieb Conor Dooley: > > I used the wikipedia table for ordering extensions when updating the > > pattern here in foo. > > ^ foo? :-) God damn it! I wrote foo, left nvim to check what the fixes tag would be, came back and added it below but did not update this part of the commit log... > > Unfortunately that table did not match canonical order, as defined by > > the RISC-V ISA Manual, which defines extension ordering in (what is > > currently) Table 41, "Standard ISA extension names". Fix things up by > > re-sorting v (vector) and adding p (packed-simd) & j (dynamic > > languages). The e (reduced integer) and g (general) extensions are still > > intentionally left out. > > > > Link: https://github.com/riscv/riscv-isa-manual/releases/tag/riscv-unpriv-pdf-from-asciidoc-15112022 # Chapter 29.5 > > Fixes: 299824e68bd0 ("dt-bindings: riscv: add new riscv,isa strings for emulators") > > Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > So I have compared the new pattern to the isa manual, > and it looks like the order checks out, so > > Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx> Thanks!
