On 22/11/2022 09:04, Hal Feng wrote: >>>> Filename based / the same as compatible (or bindings filename). >>> >>> Should I split this file into two files for "SYSCRG" and "AONCRG", which >>> maybe named as "starfive-jh7110-sys.h" and "starfive-jh7110-aon.h". Ditto >>> for the patch 8. >> >> Does not have to be, but anyway naming must follow compatible naming, so >> vendor,soc-device. > > Can I name it "starfive,jh7110-crg.h"? This file is included in > starfive,jh7110-syscrg.yaml and starfive,jh7110-aoncrg.yaml. Sounds ok. Best regards, Krzysztof