On Mon, 21 Nov 2022 09:45:11 +0100, Krzysztof Kozlowski wrote: > On 18/11/2022 02:06, Hal Feng wrote: > > From: Emil Renner Berthing <kernel@xxxxxxxx> > > > > Add all clock outputs for the StarFive JH7110 system (SYS) and > > always-on (AON) clock generator. > > > > Signed-off-by: Emil Renner Berthing <kernel@xxxxxxxx> > > Signed-off-by: Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> > > --- > > MAINTAINERS | 5 +- > > include/dt-bindings/clock/starfive-jh7110.h | 234 ++++++++++++++++++++ > > 2 files changed, 237 insertions(+), 2 deletions(-) > > create mode 100644 include/dt-bindings/clock/starfive-jh7110.h > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index e6f1060e7964..e97dac9c0ee4 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -19598,12 +19598,13 @@ M: Ion Badulescu <ionut@xxxxxxxxxx> > > S: Odd Fixes > > F: drivers/net/ethernet/adaptec/starfire* > > > > -STARFIVE JH7100 CLOCK DRIVERS > > +STARFIVE CLOCK DRIVERS > > M: Emil Renner Berthing <kernel@xxxxxxxx> > > +M: Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> > > S: Maintained > > F: Documentation/devicetree/bindings/clock/starfive,jh7100-*.yaml > > F: drivers/clk/starfive/ > > -F: include/dt-bindings/clock/starfive-jh7100*.h > > +F: include/dt-bindings/clock/starfive* > > > > STARFIVE JH7100 PINCTRL DRIVER > > M: Emil Renner Berthing <kernel@xxxxxxxx> > > diff --git a/include/dt-bindings/clock/starfive-jh7110.h b/include/dt-bindings/clock/starfive-jh7110.h > > Filename based / the same as compatible (or bindings filename). Should I split this file into two files for "SYSCRG" and "AONCRG", which maybe named as "starfive-jh7110-sys.h" and "starfive-jh7110-aon.h". Ditto for the patch 8. Best regards, Hal