> Subject: Re: [PATCH 1/4] dt-bindings: mfd: nxp,bbnsm: Add binding for nxp > bbnsm > > On 23/11/2022 08:54, Jacky Bai wrote: > > Hi Rob, > > > >> Subject: Re: [PATCH 1/4] dt-bindings: mfd: nxp,bbnsm: Add binding for > >> nxp bbnsm > >> > >> > >> On Mon, 21 Nov 2022 14:51:41 +0800, Jacky Bai wrote: > >>> Add binding for NXP BBNSM(Battery-Backed Non-Secure Module). > >>> > >>> Signed-off-by: Jacky Bai <ping.bai@xxxxxxx> > >>> --- > >>> .../devicetree/bindings/mfd/nxp,bbnsm.yaml | 103 > >> ++++++++++++++++++ > >>> 1 file changed, 103 insertions(+) > >>> create mode 100644 > >>> Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml > >>> > >> > >> My bot found errors running 'make DT_CHECKER_FLAGS=-m > >> dt_binding_check' > >> on your patch (DT_CHECKER_FLAGS is new in v5.13): > >> > >> yamllint warnings/errors: > >> > >> dtschema/dtc warnings/errors: > >> Error: > >> > Documentation/devicetree/bindings/mfd/nxp,bbnsm.example.dts:28.27-28 > >> syntax error FATAL ERROR: Unable to parse input tree > >> make[1]: *** [scripts/Makefile.lib:406: > >> Documentation/devicetree/bindings/mfd/nxp,bbnsm.example.dtb] Error 1 > >> make[1]: *** Waiting for unfinished jobs.... > >> make: *** [Makefile:1492: dt_binding_check] Error 2 > >> > > > > This error should be related to the 'interrupts = <GIC_SPI 73 > IRQ_TYPE_LEVEL_HIGH>;' > > Do we need to change it a magic number define? > > You should include a proper header. Look at other bindings. > Great thx. I missed the header file including . Will fix in V2. ^_^ BR > Best regards, > Krzysztof
