Re: [PATCH v2 1/2] dt-bindings: ufs: Add document for Unisoc UFS host controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17/11/2022 09:45, Zhe Wang wrote:
> hi Krzysztof
> 
> On Thu, Nov 17, 2022 at 1:11 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>>
>> On 16/11/2022 14:31, Zhe Wang wrote:
>>> Add Unisoc ums9620 ufs host controller devicetree document.
>>>
>>> Signed-off-by: Zhe Wang <zhe.wang1@xxxxxxxxxx>
>>
>> Thank you for your patch. There is something to discuss/improve.
>>
>>> +
>>> +  clock-names:
>>> +    items:
>>> +      - const: ufs_eb
>>> +      - const: ufs_cfg_eb
>>> +      - const: ufsh
>>> +      - const: ufsh_source
>>> +
>>> +  resets:
>>> +    maxItems: 2
>>> +
>>> +  reset-names:
>>> +    items:
>>> +      - const: ufs
>>> +      - const: ufsdev
>>
>> Both clock names and resets are still not useful. "ufs" is the name of
>> the block, so reset name of "ufs" and "ufsdev" says nothing. This is the
>> dev right?
>>
> 
> Yes, this means reset on the device side. How about the modification below?
> 
> +  clock-names:
> +    items:
> +      - const: controller_eb
> +      - const: cfg_eb
> +      - const: core
> +      - const: core_source
> +
> +  resets:
> +    maxItems: 2
> +
> +  reset-names:
> +    items:
> +      - const: controller
> +      - const: device

That's very good, thanks.

> 

Best regards,
Krzysztof




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux