On Wed, Nov 16, 2022 at 09:31:30PM +0800, Zhe Wang wrote: > Add Unisoc ums9620 ufs host controller devicetree document. > > Signed-off-by: Zhe Wang <zhe.wang1@xxxxxxxxxx> > --- > .../bindings/ufs/sprd,ums9620-ufs.yaml | 78 +++++++++++++++++++ > 1 file changed, 78 insertions(+) > create mode 100644 Documentation/devicetree/bindings/ufs/sprd,ums9620-ufs.yaml > > diff --git a/Documentation/devicetree/bindings/ufs/sprd,ums9620-ufs.yaml b/Documentation/devicetree/bindings/ufs/sprd,ums9620-ufs.yaml > new file mode 100644 > index 000000000000..ce9d05be1a6b > --- /dev/null > +++ b/Documentation/devicetree/bindings/ufs/sprd,ums9620-ufs.yaml > @@ -0,0 +1,78 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/ufs/sprd,ums9620-ufs.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Unisoc Universal Flash Storage (UFS) Controller > + > +maintainers: > + - Zhe Wang <zhe.wang1@xxxxxxxxxx> > + > +allOf: > + - $ref: ufs-common.yaml > + > +properties: > + compatible: > + const: sprd,ums9620-ufs > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 4 > + > + clock-names: > + items: > + - const: ufs_eb > + - const: ufs_cfg_eb > + - const: ufsh > + - const: ufsh_source Sounds like a parent clock to 'ufsh'? If so, it doesn't belong in 'clocks'. Use the clock API to get the parent or use 'assigned-clock-parents'. Rob
