On Tue, Nov 8, 2022 at 10:29 AM Jim Liu <jim.t90615@xxxxxxxxx> wrote: > + nin_gpios: true > + > + nout_gpios: true My comment from v1 still holds. I'd say just drop these two, it's too much trying to protect the users from themselves. > + bus-frequency: true Given that you have clocks already, what does this actually specify? Which bus? The one the GPIO is connected to? Why is it different from the frequency from the clocks? And what is it used for, why does it need to be specified? So many questions. A description is necessary. I guess the : true means it is picked up from the core schemas somehow but that doesn't make me smarter. Yours, Linus Walleij
