On 09/11/2022 04:55, Aakarsh Jain wrote: > Since,MFC v7 support was added for Exynos5420 and Exynos > 3250 SoC with same compatible string "samsung,mfc-v7".As > both SoCs having different hardware properties and having > same compatible string for both SoCs doesn't seems to be correct. > New compatible is added for Exynos3250 SOC which will > differentiate the node properties for both SoCs which > support MFC v7. > > Reviewed-by: Tommaso Merciai <tommaso.merciai@xxxxxxxxxxxxxxxxxxxx> > Suggested-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> > Signed-off-by: Aakarsh Jain <aakarsh.jain@xxxxxxxxxxx> > --- > Documentation/devicetree/bindings/media/s5p-mfc.txt | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > Beside my previous comment, please include changelog. This is v2, right? You should consider joining something like: https://www.linaro.org/events/member-training-upstream-kernel-development/ Best regards, Krzysztof
