On Fri, Oct 28, 2022 at 08:51:54AM PDT, Mark Brown wrote:
On Thu, Oct 27, 2022 at 09:12:22PM -0700, Zev Weiss wrote:
I can see why it might look that way, but I'd argue it's actually not. The
systems this is intended to support provide power to entirely separate
external devices -- think of a power distribution unit that might have
arbitrary things plugged into it. It seems to me like a property of the
hardware that those things shouldn't have their power supply turned off (or
on) just because a controller in the PDU rebooted.
We don't turn things off on reboot? We don't do anything in particular
on reboot...
Okay, perhaps not on reboot specifically, but the userspace-consumer
driver has a regulator_bulk_disable() in its .remove function, so it
would be triggered at least by a module unload (which is sort of why I
ended up with the "when software relinquishes control" wording in the
patch). If we're going to continue with the plan of using that driver
for this functionality (which seems overall quite reasonable to me), we
need a way to express that that must not happen on this hardware.
Thanks,
Zev
