On 10/26/22 06:11, Ibrahim Tilki wrote:
Adding support for Analog Devices MAX313XX series RTCs.
Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@xxxxxxxxxx>
Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@xxxxxxxxxx>
Nit below, otherwise for hwmon:
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
---
[ ... ]
+
+ if (max313xx->chip->temp_reg) {
+ hwmon = devm_hwmon_device_register_with_info(dev, client->name,
+ max313xx,
+ &max313xx_chip_info,
+ NULL);
+ if (IS_ERR(hwmon))
+ dev_warn(dev, "cannot register hwmon device: %li\n",
+ PTR_ERR(hwmon));
You could use %pe here and just pass hwmon as parameter.
+ }
+
+ return max313xx_trickle_charger_setup(dev);
+}
