On 26 October 2022 06:26:21 EEST, Bjorn Andersson <quic_bjorande@xxxxxxxxxxx> wrote: >From: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > >The DisplayPort controller's internal HPD interrupt handling is used for >cases where the HPD signal is connected to a GPIO which is pinmuxed into >the DisplayPort controller. > >Most of the logic for enabling and disabling the HPD-related interrupts >is conditioned on the presence of an EDP panel, but more generically >designs that has a downstream drm_bridge (next_bridge) could use this to >handle the HPD interrupts, instead of the internal mechanism. > >So replace the current is_edp-based guards with a check for the presence >of next_bridge. This does not sound correct. The next bridge might be a dummy bridge, not supporting the hpd. Please change this to use the enable_hpd()/disable_hpd() callbacks. This way the drm_bridge_connector framework will make sure to enable hpd handling for the bridge that is actually supposed to generate hpd events. > >Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> >Signed-off-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx> >--- > >Changes since v2: >- None -- With best wishes Dmitry
