RE: [PATCH v3 1/4] dt-bindings: mfd: Document RZ/G2L MTU3a bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof Kozlowski,

> Subject: Re: [PATCH v3 1/4] dt-bindings: mfd: Document RZ/G2L MTU3a
> bindings
> 
> On 08/10/2022 09:42, Biju Das wrote:
> 
> >>>> +                        "tgia8", "tgib8", "tgic8", "tgid8",
> >>> "tgiv8", "tgiu8";
> >>>> +      clocks = <&cpg CPG_MOD R9A07G044_MTU_X_MCK_MTU3>;
> >>>> +      power-domains = <&cpg>;
> >>>> +      resets = <&cpg R9A07G044_MTU_X_PRESET_MTU3>;
> >>>> +
> >>>> +      counter {
> >>>> +        compatible = "renesas,rz-mtu3-counter";
> >>>
> >>> You don't have any resources for the counter in DT, so you don't
> >> even
> >>> need a node here. Just have the parent driver instaniate the
> counter
> >>> driver.
> >>
> >
> > If I remove "renesas,rz-mtu3-counter" and "renesas,rz-mtu3-pwm" then
> > instantiating the counter and pwm driver from parent driver by
> > directly calling probe function is giving cyclic dependency
> error[1].
> 
> How is this related to DT? Purpose of DT is not to solve your probe
> problems.

OK.

> 
> >
> > So looks like either we need to use compatible
> > "renesas,rz-mtu3-counter" and "renesas,rz-mtu3-pwm" if these
> > functionalities to be in respective subsystem tree
> >
> 
> No, you don't need. Your driver implementation is not really related
> to the bindings.

OK. Posted [1] with the suggested binding changes.

[1] https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=684233

Cheers,
Biju




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux