Re: Re: [PATCH v2 2/3] dt-bindings: thermal: Convert loongson2 to json-schema

[朱银波 <zhuyinbo@xxxxxxxxxxx>]

> -----原始邮件-----
> 发件人: "Krzysztof Kozlowski" <krzysztof.kozlowski@xxxxxxxxxx>
> 发送时间:2022-09-21 15:05:00 (星期三)
> 收件人: "Yinbo Zhu" <zhuyinbo@xxxxxxxxxxx>, "Rafael J . Wysocki" <rafael@xxxxxxxxxx>, "Daniel Lezcano" <daniel.lezcano@xxxxxxxxxx>, "Amit Kucheria" <amitk@xxxxxxxxxx>, "Zhang Rui" <rui.zhang@xxxxxxxxx>, "Rob Herring" <robh+dt@xxxxxxxxxx>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@xxxxxxxxxx>, linux-pm@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
> 抄送: zhanghongchen <zhanghongchen@xxxxxxxxxxx>
> 主题: Re: [PATCH v2 2/3] dt-bindings: thermal: Convert loongson2 to json-schema
> 
> On 21/09/2022 03:56, Yinbo Zhu wrote:
> > Convert the loongson2 thermal binding to DT schema format using
> > json-schema.
> 
> Incorrect subject and incorrect commit msg. There is no conversion here.
Our soc architecture is the loongson2 series, so we will modify it accordingly.

> 
> > 
> > Signed-off-by: Yinbo Zhu <c>
> > ---
> > Change in v2:
> > 		1. Add description and type about the "id".	
> > 		2. Make the filename was based on compatible.
> > 
> >  .../bindings/thermal/loongson2-thermal.yaml   | 52 +++++++++++++++++++
> >  1 file changed, 52 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/thermal/loongson2-thermal.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/thermal/loongson2-thermal.yaml b/Documentation/devicetree/bindings/thermal/loongson2-thermal.yaml
> > new file mode 100644
> > index 000000000000..2994ae3a56aa
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/thermal/loongson2-thermal.yaml
> 
> 
> No improvements here. You ignore my comments, so I am going to NAK it.
I don't get your point, that dts compatible is "loongson,loongson2-thermal", so this driver file name is named
loongson2-thermal that according what you said about "Filename based on compatible."
If what I understand is not what you expect, please tell me how to modify it.
> 
> 
> > @@ -0,0 +1,52 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/thermal/loongson2-thermal.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Thermal sensors on loongson2 SoCs
> > +
> > +maintainers:
> > +  - zhanghongchen <zhanghongchen@xxxxxxxxxxx>
> > +  - Yinbo Zhu <zhuyinbo@xxxxxxxxxxx>
> > +
> > +properties:
> > +  compatible:
> > +    const: loongson,loongson2-thermal
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  id:
> > +    $ref: '//schemas/types.yaml#/definitions/uint32'
> 
> No improvements here, so let me be specific - you need to really justify
> such property or it cannot go to schema.
The loongson2_thermal.c driver need parse this "id" property.
> 
> > +    description: |
> > +      Specify the thermal sensor id.
> > +    minimum: 0
> > +    maximum: 3
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  "#thermal-sensor-cells":
> > +    const: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - id
> > +  - interrupt-parent
> 
> Why?
The interrupts of our dts do not specify an interrupt parent,
eg. interrupts = <7 IRQ_TYPE_LEVEL_LOW>
so we need to add an interrupt parent property.
> 
> > +  - interrupts
> > +  - '#thermal-sensor-cells'
> 
> Use the same style of quote: ' or ".
okay, I will have a change.
> 
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    thermal: thermal@1fe01500 {
> 
> How other similar nodes are named (in other DTS files)?
I refer qoriq platform,
    tmu@f0000 {
        compatible = "fsl,qoriq-tmu";

 You mean to modify it like this
- thermal: thermal@1fe01500 {
+ thermal@1fe01500 {

right ?


Thanks,
yinbo.
BRs.

> 
> 
> 
> Best regards,
> Krzysztof


本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。 
This email and its attachments contain confidential information from Loongson Technology , which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it.