On 21/09/2022 03:56, Yinbo Zhu wrote: > Convert the loongson2 thermal binding to DT schema format using > json-schema. Incorrect subject and incorrect commit msg. There is no conversion here. > > Signed-off-by: Yinbo Zhu <c> > --- > Change in v2: > 1. Add description and type about the "id". > 2. Make the filename was based on compatible. > > .../bindings/thermal/loongson2-thermal.yaml | 52 +++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/loongson2-thermal.yaml > > diff --git a/Documentation/devicetree/bindings/thermal/loongson2-thermal.yaml b/Documentation/devicetree/bindings/thermal/loongson2-thermal.yaml > new file mode 100644 > index 000000000000..2994ae3a56aa > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/loongson2-thermal.yaml No improvements here. You ignore my comments, so I am going to NAK it. > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/loongson2-thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Thermal sensors on loongson2 SoCs > + > +maintainers: > + - zhanghongchen <zhanghongchen@xxxxxxxxxxx> > + - Yinbo Zhu <zhuyinbo@xxxxxxxxxxx> > + > +properties: > + compatible: > + const: loongson,loongson2-thermal > + > + reg: > + maxItems: 1 > + > + id: > + $ref: '//schemas/types.yaml#/definitions/uint32' No improvements here, so let me be specific - you need to really justify such property or it cannot go to schema. > + description: | > + Specify the thermal sensor id. > + minimum: 0 > + maximum: 3 > + > + interrupts: > + maxItems: 1 > + > + "#thermal-sensor-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - id > + - interrupt-parent Why? > + - interrupts > + - '#thermal-sensor-cells' Use the same style of quote: ' or ". > + > +additionalProperties: false > + > +examples: > + - | > + thermal: thermal@1fe01500 { How other similar nodes are named (in other DTS files)? Best regards, Krzysztof
