On 20/09/2022 06:56, Siddharth Vadapalli wrote: >>> Thank you for reviewing the patch. Based on the discussion for the >>> previous series at [1], I had planned to reuse the same property >>> "ti,qsgmii-main-ports" for TI's J721e device too. The reason for this is >>> that the property represents the same feature on both devices which is >>> that of the QSGMII main port. The only difference between the two of >>> them is that J7200's CPSW5G has 4 external ports while J721e's CPSW9G >>> has 8 external ports. Thus, J7200 can have at most one QSGMII main port >>> while J721e can have up to two. Adding a new property which describes >>> the same feature appears to be redundant to me. Please let me know. >>> >> >> The trouble is that you wrote the description like it were two different >> properties (for xx this is one element, for yy this is something else). >> You need to describe the property in unified way. > > Thank you for reviewing the patch. I plan to update the description to > the following: > "Required only for QSGMII mode. Array to select the port/s for QSGMII > main mode. The size of the array corresponds to the number of QSGMII > interfaces and thus, the number of distinct QSGMII main ports, supported > by the device. If the device supports two QSGMII interfaces but only one > QSGMII interface is desired, repeat the QSGMII main port value > corresponding to the QSGMII interface in the array." > > I intend to describe the property in detail to help users understand the > property and its usage better. In the process, I might have > unintentionally made it appear as two different properties in the > previous description. I hope the new description shows that the property > describes the same feature across devices while making its usage clear > to the users at the same time. Please let me know if this is fine. Sounds good to me. Best regards, Krzysztof
