Re: [RFC v4 08/10] pwm: dwc: add of/platform support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15/09/2022 08:24, Uwe Kleine-König wrote:
Hello,

On Tue, Aug 16, 2022 at 10:14:52PM +0100, Ben Dooks wrote:
The dwc pwm controller can be used in non-PCI systems, so allow
either platform or OF based probing.

Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxx>
---
v4:
  - split the of code out of the core
  - moved the compile test code earlier
  - fixed review comments
   - used NS_PER_SEC
   - use devm_clk_get_enabled
v3:
  - changed compatible name
---
  drivers/pwm/Kconfig      |  9 +++++
  drivers/pwm/Makefile     |  1 +
  drivers/pwm/pwm-dwc-of.c | 78 ++++++++++++++++++++++++++++++++++++++++
  3 files changed, 88 insertions(+)
  create mode 100644 drivers/pwm/pwm-dwc-of.c

diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
index a9f1c554db2b..f1735653365f 100644
--- a/drivers/pwm/Kconfig
+++ b/drivers/pwm/Kconfig
@@ -192,6 +192,15 @@ config PWM_DWC_PCI
  	  To compile this driver as a module, choose M here: the module
  	  will be called pwm-dwc-pci.
+config PWM_DWC_OF
+	tristate "DesignWare PWM Controller (OF bus)

There is a missing " which results in:

	drivers/pwm/Kconfig:196:warning: multi-line strings not supported

Best regards
Uwe

Thanks, fixed.




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux