On 31/08/2022 14:55, Chengci.Xu wrote: > This patch adds descriptions for mt8188 IOMMU which also use ARM > Short-Descriptor translation table format. Do not use "This commit/patch". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > then: > required: > diff --git a/include/dt-bindings/memory/mediatek,mt8188-memory-port.h b/include/dt-bindings/memory/mediatek,mt8188-memory-port.h > new file mode 100644 > index 000000000000..9363e132c43a > --- /dev/null > +++ b/include/dt-bindings/memory/mediatek,mt8188-memory-port.h > @@ -0,0 +1,482 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */ Why do you license it under BSD-3 clause? Best regards, Krzysztof