On Mon 15 Aug 2022 at 14:34, Yu Tu <yu.tu@xxxxxxxxxxx> wrote: > Hi Jerome, > > On 2022/8/10 21:47, Jerome Brunet wrote: >> [ EXTERNAL EMAIL ] >> On Fri 05 Aug 2022 at 16:57, Yu Tu <yu.tu@xxxxxxxxxxx> wrote: >> */ [... ] >>> +#define ANACTRL_FIXPLL_CTRL0 (0x0010 << 2) >> I already commented on the "<< 2" . Remove them please. > Sorry, maybe I didn't pay attention to this comment earlier. A little bit > of a question why is this not okay? I understand isn't it better for the > compiler to help with this calculation itself? Because it is aweful to read Also please trim your replies. It is a bit annoying to search for your comments in the replies