On Fri, 19 Aug 2022 at 02:59, Stephen Boyd <sboyd@xxxxxxxxxx> wrote: > > Quoting Jagan Teki (2022-08-18 05:41:23) > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + const: xin24m > > + > > + rockchip,grf: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + Phandle to the syscon managing the "general register files" (GRF), > > + if missing pll rates are not changeable, due to the missing pll > > + lock status. > > + > > +required: > > + - compatible > > + - reg > > + - "#clock-cells" > > + - "#reset-cells" > > Why aren't clocks required? I don't see any clocks being used by cru in rv1126 [1] so that is the reason I didn't add any. Let me know if it is something that is mandatory to add even if it's unused. [1] https://github.com/rockchip-linux/kernel/blob/develop-4.19/arch/arm/boot/dts/rv1126.dtsi#L1074 Thanks, Jagan.