On 02/08/2022 01:09, Florian Fainelli wrote:
> Add support for configuring the Self Refresh Power Down (SRPD)
> inactivity timeout on Broadcom STB chips. This is used to conserve power
> when the DRAM activity is reduced.
>
> +static int __maybe_unused brcmstb_memc_resume(struct device *dev)
> +{
> + struct brcmstb_memc *memc = dev_get_drvdata(dev);
> +
> + if (memc->timeout_cycles == 0)
> + return 0;
> +
> + return brcmstb_memc_srpd_config(memc, memc->timeout_cycles);
> +}
> +
> +static SIMPLE_DEV_PM_OPS(brcmstb_memc_pm_ops, brcmstb_memc_suspend,
> + brcmstb_memc_resume);
> +
> +static struct platform_driver brcmstb_memc_driver = {
> + .probe = brcmstb_memc_probe,
> + .remove = brcmstb_memc_remove,
> + .driver = {
> + .name = "brcmstb_memc",
> + .owner = THIS_MODULE,
No need, run coccinelle.
> + .of_match_table = brcmstb_memc_of_match,
> + .pm = &brcmstb_memc_pm_ops,
Shouldn't this be pm_ptr()? and then no need for __maybe_unused in
brcmstb_memc_resume/suspend.
> + },
> +};
> +module_platform_driver(brcmstb_memc_driver);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Broadcom");
> +MODULE_DESCRIPTION("DDR SRPD driver for Broadcom STB chips");
Best regards,
Krzysztof
