On Tue, Aug 9, 2022 at 11:52 AM Dmitry Rokosov <DDRokosov@xxxxxxxxxxxxxx> wrote: > On Sat, Aug 06, 2022 at 03:55:23PM +0100, Jonathan Cameron wrote: > > > > > + indio_dev->modes = 0; /* setup buffered mode later */ > > > > > > > > Why explicit assignment to 0? Doesn't kzalloc() do it for you? > > > > > > kzalloc() will do it for me, of course. Previously, I initialized modes to > > > INDIO_DIRECT_MODE to just provide default value for that. Jonathan > > > suggested to replace it with 0. > > > > I did? I wonder what I was smoking that day. > > Should be set to INDIO_DIRECT_MODE as you had it previously. > > > > (From what I recall it will work either way but we have in the past had > > core code that checked this and may do again in the future so drivers should > > still be setting it to specify they provide sysfs interfaces to directly read > > the channels). > > Jonathan, really sorry I referred to you. I'm confused. This comment was > from Andy in the v3 discussion: > > https://lore.kernel.org/linux-iio/CAHp75Vc0+ckNnm2tzLMPrjeFRjwoj3zy0C4koNShFRG3kP8b6w@xxxxxxxxxxxxxx/ Indeed. I was confused by the comment. My understanding at that time was that the triggered mode is inevitable and hence assigning to something which _will_ be reassigned later makes a little sense. So, does it mean that triggered mode is optional and might not be set? In such a case the comment is misleading. -- With Best Regards, Andy Shevchenko
