Re: [PATCH V3 5/6] arm64: dts: meson: add S4 Soc Peripheral clock controller in DT

[Yu Tu <yu.tu@xxxxxxxxxxx>]

Hi Krzysztof,
    Thank you for your reply.

On 2022/8/5 17:16, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On 05/08/2022 10:57, Yu Tu wrote:
> > Added information about the S4 SOC Peripheral Clock controller in DT.
> >
> > Signed-off-by: Yu Tu <yu.tu@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 26 +++++++++++++++++++++++
> >   1 file changed, 26 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> > index a816b1f7694b..71be1dda15a2 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> > +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> > @@ -6,6 +6,8 @@
> >   #include <dt-bindings/interrupt-controller/irq.h>
> >   #include <dt-bindings/interrupt-controller/arm-gic.h>
> >   #include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/clock/amlogic,s4-pll-clkc.h>
> > +#include <dt-bindings/clock/amlogic,s4-clkc.h>
> >   
> >   / {
> >   	cpus {
> > @@ -100,6 +102,30 @@ clkc_pll: pll-clock-controller@8000 {
> >   				#clock-cells = <1>;
> >   			};
> >   
> > +			clkc_periphs: periphs-clock-controller {
>
> Node names should be generic, so "clock-controller"
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
> You miss here unit address. Test your DTS with dtbs check and with
> regular compile with W=1.
I will change to clkc_periphs: clock-controller@0 {.
Is that okay?
> Best regards,
> Krzysztof
>
> .