On Tue, Aug 02, 2022 at 10:52:25AM +0200, Krzysztof Kozlowski wrote: > On 01/08/2022 11:42, Naga Sureshkumar Relli wrote: > > - enum: > > - - microchip,mpfs-spi > > - - microchip,mpfs-qspi > > + oneOf: > > + - description: Microchip's Polarfire SoC SPI controller. > > + const: microchip,mpfs-spi > > + - description: Microchip's Polarfire SoC QSPI controller. > Useless descriptions - they repeat compatible. Just keep it as enum and > skip descriptions. What value do they bring? Someone not familiar with the full Microchip product line might not be aware of the expansion of mpfs, it's not blindingly obvious.
Attachment:
signature.asc
Description: PGP signature