On 01/08/2022 11:42, Naga Sureshkumar Relli wrote: > Add compatible string for Microchip CoreQSPI controller. > > Signed-off-by: Naga Sureshkumar Relli <nagasuresh.relli@xxxxxxxxxxxxx> > --- > .../devicetree/bindings/spi/microchip,mpfs-spi.yaml | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml > index 7326c0a28d16..b65f4e070796 100644 > --- a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml > +++ b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml > @@ -14,9 +14,13 @@ allOf: > > properties: > compatible: > - enum: > - - microchip,mpfs-spi > - - microchip,mpfs-qspi > + oneOf: > + - description: Microchip's Polarfire SoC SPI controller. > + const: microchip,mpfs-spi > + - description: Microchip's Polarfire SoC QSPI controller. Useless descriptions - they repeat compatible. Just keep it as enum and skip descriptions. What value do they bring? > + const: microchip,mpfs-qspi > + - description: Microchip's FPGA QSPI controller. > + const: microchip,coreqspi-rtl-v2 Best regards, Krzysztof
