On 30/07/2022 16:26, Arınç ÜNAL wrote: > Make trivial changes on the binding. > > - Update title to include MT7531 switch. > - Add me as a maintainer. List maintainers in alphabetical order by first > name. > - Add description to compatible strings. > - Fix MCM description. mediatek,mcm is not used on MT7623NI. > - Add description for reset-gpios. > - Remove quotes from $ref: "dsa.yaml#". > > Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx> > --- > .../bindings/net/dsa/mediatek,mt7530.yaml | 27 ++++++++++++++----- > 1 file changed, 20 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > index 17ab6c69ecc7..541984a7d2d4 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > @@ -4,12 +4,13 @@ > $id: http://devicetree.org/schemas/net/dsa/mediatek,mt7530.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Mediatek MT7530 Ethernet switch > +title: Mediatek MT7530 and MT7531 Ethernet Switches > > maintainers: > - - Sean Wang <sean.wang@xxxxxxxxxxxx> > + - Arınç ÜNAL <arinc.unal@xxxxxxxxxx> > - Landen Chao <Landen.Chao@xxxxxxxxxxxx> > - DENG Qingfang <dqfext@xxxxxxxxx> > + - Sean Wang <sean.wang@xxxxxxxxxxxx> > > description: | > Port 5 of mt7530 and mt7621 switch is muxed between: > @@ -66,6 +67,14 @@ properties: > - mediatek,mt7531 > - mediatek,mt7621 > > + description: | > + mediatek,mt7530: > + For standalone MT7530 and multi-chip module MT7530 in MT7623AI SoC. > + mediatek,mt7531: > + For standalone MT7531. > + mediatek,mt7621: > + For multi-chip module MT7530 in MT7621AT, MT7621DAT and MT7621ST SoCs. If compatible: is changed to oneOf, you can use description for each item. Look at board compatibles (arm/fsl.yaml) > + > reg: > maxItems: 1 > > @@ -79,7 +88,7 @@ properties: > gpio-controller: > type: boolean > description: > - if defined, MT7530's LED controller will run on GPIO mode. > + If defined, MT7530's LED controller will run on GPIO mode. > > "#interrupt-cells": > const: 1 > @@ -98,11 +107,15 @@ properties: > mediatek,mcm: > type: boolean > description: > - if defined, indicates that either MT7530 is the part on multi-chip > - module belong to MT7623A has or the remotely standalone chip as the > - function MT7623N reference board provided for. > + Used for MT7621AT, MT7621DAT, MT7621ST and MT7623AI SoCs which the MT7530 > + switch is a part of the multi-chip module. Does this mean it is valid only on these variants? If yes, this should have a "mediatek,mcm:false" in allOf:if:then as separate patch (with this change in description). > > reset-gpios: > + description: > + GPIO to reset the switch. Use this if mediatek,mcm is not used. The same. Example: https://elixir.bootlin.com/linux/v5.17-rc2/source/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml#L155 > + This property is optional because some boards share the reset line with > + other components which makes it impossible to probe the switch if the > + reset line is used. > maxItems: 1 > > reset-names: > @@ -148,7 +161,7 @@ required: > - reg > > allOf: > - - $ref: "dsa.yaml#" > + - $ref: dsa.yaml# > - if: > required: > - mediatek,mcm Best regards, Krzysztof
