On Fri, Jul 29, 2022 at 07:33:47PM +0300, Ivan Bornyakov wrote: > On Fri, Jul 29, 2022 at 11:01:24AM +0200, Daniel Glöckner wrote: > > On Tue, Jul 19, 2022 at 02:23:35PM +0300, Ivan Bornyakov wrote: > > > +properties: > > > + compatible: > > > + enum: > > > + - lattice,ecp5-fpga-mgr > > > > Since this driver uses the same interface as the existing > > drivers/fpga/machxo2-spi.c driver, wouldn't it be advisable to use a > > similar compatible id, i.e. lattice,ecp5-slave-spi? > > > > To quote Krzysztof Kozlowski from v1 review: > > Do not encode interface name in compatible so no "spi" > > See https://lore.kernel.org/linux-fpga/044a9736-a4ec-c250-7755-c80a5bcbe38b@xxxxxxxxxx/ true... MachXO2 to MachXO5 and those Nexus chips speak that protocol both over spi and i2c and the position in the device tree decides which one it should be. Maybe the compatible string in the existing driver should be changed to lattice,machxo2. After all there is no other MachXO2-specific interface/protocol except maybe jtag. Best regards, Daniel
