Hi, On Tue, Jul 19, 2022 at 02:23:35PM +0300, Ivan Bornyakov wrote: > +properties: > + compatible: > + enum: > + - lattice,ecp5-fpga-mgr Since this driver uses the same interface as the existing drivers/fpga/machxo2-spi.c driver, wouldn't it be advisable to use a similar compatible id, i.e. lattice,ecp5-slave-spi? > +required: > + - compatible > + - reg > + - program-gpios > + - init-gpios > + - done-gpios I think some of the GPIOs can be made optional by reading the status register or using the refresh command, assuming the slave spi interface stayed enabled after previous programming and we are not dealing with several chained FPGAs. But that can of course be left as an exercise for other developers. Best regards, Daniel
