On Fri, Jul 29, 2022 at 11:01:24AM +0200, Daniel Glöckner wrote: > Hi, > > On Tue, Jul 19, 2022 at 02:23:35PM +0300, Ivan Bornyakov wrote: > > +properties: > > + compatible: > > + enum: > > + - lattice,ecp5-fpga-mgr > > Since this driver uses the same interface as the existing > drivers/fpga/machxo2-spi.c driver, wouldn't it be advisable to use a > similar compatible id, i.e. lattice,ecp5-slave-spi? > To quote Krzysztof Kozlowski from v1 review: > Do not encode interface name in compatible so no "spi" See https://lore.kernel.org/linux-fpga/044a9736-a4ec-c250-7755-c80a5bcbe38b@xxxxxxxxxx/ > > +required: > > + - compatible > > + - reg > > + - program-gpios > > + - init-gpios > > + - done-gpios > > I think some of the GPIOs can be made optional by reading the status > register or using the refresh command, assuming the slave spi interface > stayed enabled after previous programming and we are not dealing with > several chained FPGAs. But that can of course be left as an exercise for > other developers. I would prefer the latter.
