On 22/07/2022 03:40, hui.liu wrote: > Hi, Krzysztof > > That's the comment about reg and reg-names description: >>> + reg: >>> + description: | >>> + Physical address base for gpio base registers. There are 8 >>> GPIO >>> + physical address base in mt8188. >> >> Redundant description, skip it. You should list the instead and >> describe >> each of it. >> >>> + maxItems: 8 >>> + >>> + reg-names: >>> + description: | >>> + Gpio base register names. >> >> Redundant description, skip it. >> >>> + maxItems: 8 >> >> You need to list the items instead. > > I plan to update reg and reg-names as the following: > reg: > description: | > Physical address base for gpio base registers. There are 6 > different GPIO physical address bases in mt8188. > minItems: 6 > maxItems: 6 You should rather have here items with description: items: - description: what is it - description: what is it .... > > reg-names: > items: > - const: iocfg0 > - const: iocfg_rm > - const: iocfg_lt > - const: iocfg_lm > - const: iocfg_rt > - const: eint > > Is it right? > > Thanks. > Best regards, Krzysztof
