Re: [PATCH 1/3] arm: socfpga: Enable ECC of L2 and OCRAM on startup.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 10/01/2014 04:10 PM, Dinh Nguyen wrote:

On 10/1/14, 4:07 PM, Thor Thayer wrote:
On 10/01/2014 12:13 PM, Dinh Nguyen wrote:
On 10/1/14, 11:31 AM, tthayer@xxxxxxxxxxxxxxxxxxxxx wrote:
From: Thor Thayer <tthayer@xxxxxxxxxxxxxxxxxxxxx>

[...]
     static void socfpga_cyclone5_restart(enum reboot_mode mode, const
char *cmd)
@@ -98,6 +101,13 @@ static void socfpga_cyclone5_restart(enum
reboot_mode mode, const char *cmd)
       writel(temp, rst_manager_base_addr + SOCFPGA_RSTMGR_CTRL);
   }
   +static void __init socfpga_cyclone5_init(void)
+{
+    of_platform_populate(NULL, of_default_bus_match_table,
+                 NULL, NULL);
Why is this needed?

Dinh
Hi Dinh.

Are you asking why the of_platform_populate() is needed? If so, it is
used to kick off discovery of devices at the root of the tree.
I was asking about of_platform populate(). This was removed in this commit:

8b5c18f05 ARM: l2c: socfpga: convert to generic l2c OF initialisation

Just trying to understand what's the need to add it back?

Dinh
It is used to kick off discovery of devices at the root of the tree. This is needed when .init_machine was defined because we're not using the default implementation (which called this function).

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux