On Sat, Jul 9, 2022 at 6:22 AM kernel test robot <lkp@xxxxxxxxx> wrote: > > Hi "Nuno, > > I love your patch! Yet something to improve: > > [auto build test ERROR on dtor-input/next] > [also build test ERROR on next-20220708] > [cannot apply to brgl/gpio/for-next hid/for-next linus/master v5.19-rc5] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Nuno-S/adp5588-keys-refactor-and-fw-properties-support/20220708-173730 > base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next > config: x86_64-randconfig-a013 (https://download.01.org/0day-ci/archive/20220709/202207091223.nBzeL6dk-lkp@xxxxxxxxx/config) > compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 > reproduce (this is a W=1 build): > # https://github.com/intel-lab-lkp/linux/commit/64267ff775fd4b945fb916a10187be1c15faa165 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Nuno-S/adp5588-keys-refactor-and-fw-properties-support/20220708-173730 > git checkout 64267ff775fd4b945fb916a10187be1c15faa165 > # save the config file > mkdir build_dir && cp config build_dir/.config > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All errors (new ones prefixed by >>): > > drivers/input/keyboard/adp5588-keys.c: In function 'adp5588_gpio_add': > >> drivers/input/keyboard/adp5588-keys.c:263:18: error: 'struct gpio_chip' has no member named 'of_node'; did you mean 'fwnode'? > 263 | kpad->gc.of_node = kpad->client->dev.of_node; > | ^~~~~~~ > | fwnode Yes, exactly the point why of_node is bad to have. In legacy code like this you need to guard access to it with #ifdef CONFIG_OF_GPIO IIRC. -- With Best Regards, Andy Shevchenko
